Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove container all from description #1497

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Oct 30, 2024

What does this PR do?

Removes the container name all from the container overrides description

Motivation

Support case

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Describe the DatadogAgent CRD and check that the description was updated to remove references to the all container

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added bug Something isn't working documentation Improvements or additions to documentation labels Oct 30, 2024
@khewonc khewonc added this to the v1.11.0 milestone Oct 30, 2024
@khewonc khewonc marked this pull request as ready for review October 30, 2024 18:48
@khewonc khewonc requested review from a team as code owners October 30, 2024 18:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.70%. Comparing base (a33ab18) to head (fadd88b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage   48.70%   48.70%           
=======================================
  Files         224      224           
  Lines       19845    19845           
=======================================
  Hits         9666     9666           
  Misses       9670     9670           
  Partials      509      509           
Flag Coverage Δ
unittests 48.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33ab18...fadd88b. Read the comment docs.

@khewonc khewonc merged commit 05c1d4b into main Oct 30, 2024
24 checks passed
@khewonc khewonc deleted the khewonc/remove-docs-all branch October 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants