Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Orch] Set CRDs in cases of revoking config (#1505) #1510

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Cherry-pick #1505

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@fanny-jiang fanny-jiang added the bug Something isn't working label Nov 5, 2024
@fanny-jiang fanny-jiang added this to the v1.10.0 milestone Nov 5, 2024
@fanny-jiang fanny-jiang requested a review from a team as a code owner November 5, 2024 15:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.90%. Comparing base (1e4e2f4) to head (bfdab87).

Files with missing lines Patch % Lines
pkg/remoteconfig/orchestrator_k8s_crd.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            v1.10    #1510   +/-   ##
=======================================
  Coverage   48.90%   48.90%           
=======================================
  Files         225      225           
  Lines       19828    19828           
=======================================
  Hits         9696     9696           
  Misses       9628     9628           
  Partials      504      504           
Flag Coverage Δ
unittests 48.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/remoteconfig/orchestrator_k8s_crd.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4e2f4...bfdab87. Read the comment docs.

@fanny-jiang fanny-jiang merged commit 54f69e8 into v1.10 Nov 5, 2024
19 checks passed
@fanny-jiang fanny-jiang deleted the fanny/cherry-pick-1505 branch November 5, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants