Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local as valid type for autoscaler source #1513

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jennchenn
Copy link
Member

@jennchenn jennchenn commented Nov 5, 2024

What does this PR do?

Add Local as valid type for autoscaler source.

Motivation

Implementing local fallback

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Cluster Agent: v7.56.0

Describe your test plan

Will be tested as part of changes made to autoscaling controller for local fallback.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@jennchenn jennchenn added enhancement New feature or request qa/skip-qa labels Nov 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.66%. Comparing base (6ff015c) to head (69f76ab).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1513   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         226      226           
  Lines       20363    20363           
=======================================
  Hits         9909     9909           
  Misses       9937     9937           
  Partials      517      517           
Flag Coverage Δ
unittests 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...i/datadoghq/v1alpha1/datadogpodautoscaler_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff015c...69f76ab. Read the comment docs.

@jennchenn jennchenn marked this pull request as ready for review November 27, 2024 22:21
@jennchenn jennchenn requested a review from a team as a code owner November 27, 2024 22:21
@jennchenn jennchenn force-pushed the jenn/CASCL-102_adapt-dpai-local-fallback branch from 28a13fb to 69f76ab Compare November 27, 2024 22:22
@jennchenn jennchenn added this to the v1.12.0 milestone Nov 27, 2024
@jennchenn jennchenn merged commit 993280d into main Dec 4, 2024
21 checks passed
@jennchenn jennchenn deleted the jenn/CASCL-102_adapt-dpai-local-fallback branch December 4, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants