Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include ADP container in certain pod-wide volume mount overrides #1532

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

tobz
Copy link
Member

@tobz tobz commented Nov 20, 2024

What does this PR do?

This PR adds the Agent Data Plane container to the list of containers which receive an overridden runtimesocketdir and kubelet-ca volume mount.

Motivation

This is needed to ensure ADP can access the proper socket paths on the host.

Additional Notes

N/A

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: N/A
  • Cluster Agent: N/A

Describe your test plan

Ran Operator locally in Kind cluster and observed the ADP container got the same runtimesocketdir and kubelet-ca volume mounts as other containers in Agent pod.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tobz tobz requested a review from a team as a code owner November 20, 2024 14:40
@tobz tobz added the bug Something isn't working label Nov 20, 2024
@tobz tobz added this to the v1.11.0 milestone Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.88%. Comparing base (f8fc41d) to head (f5f630a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1532   +/-   ##
=======================================
  Coverage   48.88%   48.88%           
=======================================
  Files         226      226           
  Lines       20144    20146    +2     
=======================================
+ Hits         9847     9849    +2     
  Misses       9782     9782           
  Partials      515      515           
Flag Coverage Δ
unittests 48.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nternal/controller/datadogagent/override/global.go 48.11% <100.00%> (+0.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fc41d...f5f630a. Read the comment docs.

---- 🚨 Try these New Features:

@tobz tobz merged commit 9085046 into main Nov 20, 2024
20 checks passed
@tobz tobz deleted the tobz/fix-global-vol-mounts-adp branch November 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants