Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooling] use generated GITHUB_TOKEN for authentication #1541

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

Attempts to use the automatic generated token for authentication

Motivation

sporadic rate limits https://datadoghq.atlassian.net/browse/CECO-628

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.66%. Comparing base (345912e) to head (7d7a490).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1541   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         226      226           
  Lines       20363    20363           
=======================================
  Hits         9909     9909           
  Misses       9937     9937           
  Partials      517      517           
Flag Coverage Δ
unittests 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345912e...7d7a490. Read the comment docs.

@tbavelier tbavelier merged commit 6ff015c into main Nov 27, 2024
20 checks passed
@tbavelier tbavelier deleted the tbavelier/ceco-628 branch November 27, 2024 15:26
tbavelier added a commit that referenced this pull request Nov 28, 2024
* use generated GITHUB_TOKEN for authentication

* fix whitespace
@tbavelier tbavelier added this to the v1.11.0 milestone Nov 28, 2024
tbavelier added a commit that referenced this pull request Dec 2, 2024
* use generated GITHUB_TOKEN for authentication
* fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants