Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Secrets management in Operator 1.11+ #1555

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

Documents feature introduced by #1395

Motivation

What inspired you to submit this pull request?

Additional Notes

This requires Operator 1.11+

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added documentation Improvements or additions to documentation qa/skip-qa labels Dec 11, 2024
@tbavelier tbavelier added this to the v1.11.0 milestone Dec 11, 2024
@tbavelier tbavelier requested review from a team as code owners December 11, 2024 12:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.66%. Comparing base (c58579a) to head (55c06c4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files         226      226           
  Lines       20370    20370           
=======================================
  Hits         9913     9913           
  Misses       9940     9940           
  Partials      517      517           
Flag Coverage Δ
unittests 48.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58579a...55c06c4. Read the comment docs.

@drichards-87 drichards-87 self-assigned this Dec 11, 2024
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback from Docs and approved the PR.

docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
docs/secret_management.md Outdated Show resolved Hide resolved
tbavelier and others added 7 commits December 13, 2024 12:28
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
@tbavelier tbavelier merged commit 1793719 into main Dec 13, 2024
20 checks passed
@tbavelier tbavelier deleted the tbavelier/secrets-revamp branch December 13, 2024 12:35
tbavelier added a commit that referenced this pull request Dec 16, 2024
Co-authored-by: Celene <celene@datadoghq.com>
tbavelier added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants