Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API violation from OTel Agent #1607

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Jan 7, 2025

What does this PR do?

Fixes API violation from #1559

Motivation

https://github.com/DataDog/datadog-operator/actions/runs/12434980195/job/34719814433#step:6:43 API rule violations occur when running make generate

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Verify that error has been resolved in CI: https://github.com/DataDog/datadog-operator/actions/runs/12659013902/job/35277172303?pr=1607 looks good

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@swang392 swang392 added bug Something isn't working qa/skip-qa labels Jan 7, 2025
@swang392 swang392 added this to the v1.12.0 milestone Jan 7, 2025
@swang392 swang392 requested review from a team as code owners January 7, 2025 20:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.94%. Comparing base (87f8143) to head (b869098).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1607   +/-   ##
=======================================
  Coverage   48.94%   48.94%           
=======================================
  Files         227      227           
  Lines       20636    20636           
=======================================
  Hits        10101    10101           
  Misses      10010    10010           
  Partials      525      525           
Flag Coverage Δ
unittests 48.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f8143...b869098. Read the comment docs.

@swang392 swang392 merged commit db00883 into main Jan 7, 2025
23 checks passed
@swang392 swang392 deleted the swang392/api-rule-violation branch January 7, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants