-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(injector): allow configuring injector version #1614
base: main
Are you sure you want to change the base?
feat(injector): allow configuring injector version #1614
Conversation
This commit allows users to optionally pin the injector version to a specifc image tag.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
+ Coverage 48.93% 48.97% +0.04%
==========================================
Files 217 217
Lines 20892 20910 +18
==========================================
+ Hits 10223 10241 +18
Misses 10129 10129
Partials 540 540
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
What does this PR do?
This commit allows users to optionally pin the injector version to a specific image tag for the Single Step APM Instrumentation in Kubernetes.
Motivation
Both internally during development of SSI and externally for our customers, it's useful to be able to pin the injector version. We already support this in the datadog Helm chart and this expands the functionality for customers using the operator.
Additional Notes
This is my first change to this repo! Let me know if I missed anything.
Minimum Agent Versions
Describe your test plan
I setup minikube locally with a registry. I ran the following to install my operator based on the docs:
I then added the following config to
examples/datadogagent/datadog-agent-minimum.yaml
and ran the script for a DatadogAgent resource:Finally, I deployed an example JS app to the test-1 namespace and ensured it got the old injector version:
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label