Add new version of DatadogPodAutoscaler CRD #1621

jbartosik · 2025-01-13T15:28:26Z

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

Agent: vX.Y.Z
Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
PR has a milestone or the qa/skip-qa label

codecov-commenter · 2025-01-13T16:05:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.28%. Comparing base (a839ab9) to head (fb5a478).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files         216      216           
  Lines       20662    20662           
=======================================
  Hits        10184    10184           
  Misses       9942     9942           
  Partials      536      536

Flag	Coverage Δ
unittests	`49.28% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a839ab9...fb5a478. Read the comment docs.

`operator-sdk create api --group datadoghq --kind DatadogPodAutoscaler --version v2alpha1`

Similar to v1alpah1, with the following changes: - `spec.policy` renamed to `spec.actuation` - `spec.policy.applyMode` replaced with `spec.actuation.mode` (allowed values `Apply` and `Preview`) - `spec.policy.upscale.match` and `spec.policy.donwscale.match` removed - `spec.policy.targets` renamed to `spec.policy.objectives` - `sepc.policy.contraints.containers[].limits` removed

vboulineau · 2025-01-21T10:14:09Z

PROJECT

+  domain: com
+  group: datadoghq
+  kind: DatadogPodAutoscaler
+  path: github.com/DataDog/datadog-operator/api/datadoghq/v2alpha1


I don't think we'll expose a v2 for GA, so that version will probably v1beta1 or v1alpha2

vboulineau · 2025-01-21T10:18:26Z

api/datadoghq/v2alpha1/datadogpodautoscaler_types.go

+	// It's also possible to selectively deactivate upscale, downscale or update actions thanks to the `Upscale`, `Downscale` and `Update` fields.
+	// +optional
+	// +kubebuilder:default=All
+	Mode DatadogPodAutoscalerActuationMode `json:"applyMode"`


Suggested change

Mode DatadogPodAutoscalerActuationMode `json:"applyMode"`

Mode DatadogPodAutoscalerActuationMode `json:"mode"`

vboulineau · 2025-01-21T10:19:01Z

api/datadoghq/v2alpha1/datadogpodautoscaler_types.go

+	Update *DatadogPodAutoscalerUpdatePolicy `json:"update,omitempty"`
+
+	// Upscale defines the policy to scale up the target resource.
+	Upscale *DatadogPodAutoscalerScalingPolicy `json:"upscale,omitempty"`


Wasn't there a proposal to change to scaleUp and scaleDown?

vboulineau · 2025-01-21T10:19:28Z

api/datadoghq/v2alpha1/datadogpodautoscaler_types.go

+type DatadogPodAutoscalerActuation struct {
+	// Mode determines recommendations that should be applied by the controller:
+	// - All: Apply all recommendations (regular and manual).
+	// - Manual: Apply only manual recommendations (recommendations manually validated by user in the Datadog app).


vboulineau · 2025-01-21T10:24:28Z

api/datadoghq/v2alpha1/datadogpodautoscaler_types.go

+	Type DatadogPodAutoscalerTargetValueType `json:"type"`
+
+	// Absolute defines the absolute value of the target (for instance 500 millicores).
+	Absolute *resource.Quantity `json:"absolute,omitempty"`


Note: we need to keep Absolute for future cases but we need to disallow it for multi-dim and vertical scaling.

vboulineau · 2025-01-21T10:26:09Z

config/rbac/kustomization.yaml

+kind: Kustomization# For each CRD, "Editor" and "Viewer" roles are scaffolded by
+# default, aiding admins in cluster management. Those roles are


This can be removed as we don't ship the CRD in the operator

vboulineau · 2025-01-21T10:26:22Z

config/samples/datadoghq_v2alpha1_datadogpodautoscaler.yaml

@@ -0,0 +1,9 @@
+apiVersion: datadoghq.com/v2alpha1


This can also be removed as we don't ship the CRD with the operator

vboulineau · 2025-01-21T10:29:38Z

api/datadoghq/v2alpha1/datadogpodautoscaler_types.go

+	// Actuation defines how recommendations should be applied.
+	// +optional
+	// +kubebuilder:default={}
+	Actuation *DatadogPodAutoscalerActuation `json:"actuation,omitempty"`


Still not a big fan of presenting the actuation name to customers but LGTM if we don't find anything else.

Mark DDPA v1alpha1 as the storage version

56ab290

jbartosik changed the title ~~Cascl 120 new ddas crd~~ Add new version of DatadogPodAutoscaler CRD Jan 13, 2025

jbartosik added enhancement New feature or request qa/skip-qa labels Jan 13, 2025

jbartosik force-pushed the CASCL-120-new-ddas-crd branch 3 times, most recently from 3c1e64d to 2f562af Compare January 13, 2025 15:55

jbartosik force-pushed the CASCL-120-new-ddas-crd branch 3 times, most recently from 8d7bcb7 to 32b049f Compare January 13, 2025 16:14

jbartosik added 2 commits January 13, 2025 16:15

Generate DDPA v2alpha1

f6b7245

`operator-sdk create api --group datadoghq --kind DatadogPodAutoscaler --version v2alpha1`

jbartosik force-pushed the CASCL-120-new-ddas-crd branch from 32b049f to fb5a478 Compare January 13, 2025 16:15

jbartosik marked this pull request as ready for review January 13, 2025 16:33

jbartosik requested a review from a team as a code owner January 13, 2025 16:33

levan-m requested a review from a team January 13, 2025 16:37

vboulineau reviewed Jan 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new version of DatadogPodAutoscaler CRD #1621

Add new version of DatadogPodAutoscaler CRD #1621

jbartosik commented Jan 13, 2025

codecov-commenter commented Jan 13, 2025 •

edited

Loading

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

vboulineau Jan 21, 2025

	Mode DatadogPodAutoscalerActuationMode `json:"applyMode"`
	Mode DatadogPodAutoscalerActuationMode `json:"mode"`

		kind: Kustomization# For each CRD, "Editor" and "Viewer" roles are scaffolded by
		# default, aiding admins in cluster management. Those roles are

Add new version of DatadogPodAutoscaler CRD #1621

Are you sure you want to change the base?

Add new version of DatadogPodAutoscaler CRD #1621

Conversation

jbartosik commented Jan 13, 2025

What does this PR do?

Motivation

Additional Notes

Minimum Agent Versions

Describe your test plan

Checklist

codecov-commenter commented Jan 13, 2025 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 13, 2025 •

edited

Loading