Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daemonset status duplication in DDA when DS can't be created (#1629) #1632

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Jan 17, 2025

What does this PR do?

cherry-pick #1629 and apply changes to correct files which were moved in main.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

* Add failing test

* Fix daemonset status duplication in DDA when DS can't be created
@levan-m levan-m added the bug Something isn't working label Jan 17, 2025
@levan-m levan-m added this to the v1.12.0 milestone Jan 17, 2025
@levan-m levan-m requested a review from a team as a code owner January 17, 2025 18:03
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.50000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 48.87%. Comparing base (c54912e) to head (1c83ac1).

Files with missing lines Patch % Lines
api/datadoghq/v2alpha1/condition.go 24.24% 24 Missing and 1 partial ⚠️
...ler/datadogagent/controller_reconcile_v2_common.go 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.12    #1632      +/-   ##
==========================================
+ Coverage   48.78%   48.87%   +0.08%     
==========================================
  Files         235      235              
  Lines       21145    21143       -2     
==========================================
+ Hits        10315    10333      +18     
+ Misses      10291    10269      -22     
- Partials      539      541       +2     
Flag Coverage Δ
unittests 48.87% <27.50%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller/datadogagent/controller_reconcile_agent.go 53.44% <100.00%> (ø)
...ler/datadogagent/controller_reconcile_v2_common.go 29.96% <20.00%> (ø)
api/datadoghq/v2alpha1/condition.go 12.98% <24.24%> (+7.83%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54912e...1c83ac1. Read the comment docs.

@levan-m levan-m merged commit a715d8c into v1.12 Jan 17, 2025
16 checks passed
@levan-m levan-m deleted the levan-m/1.12/ds-dedup-status branch January 17, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants