Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing v2alpha1 #374

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Introducing v2alpha1 #374

merged 4 commits into from
Sep 14, 2021

Conversation

CharlyF
Copy link
Contributor

@CharlyF CharlyF commented Sep 13, 2021

What does this PR do?

operator-sdk edit --multigroup=true
  • Introduce the storage flag and update the controller-gen to 0.5.0.
  • Fix 2 json flag in the types: containerSymlinksPath and ConfigDirSpec.Items using the atomic list and here.

Motivation

We are going to introduce a new API that will carry breaking changes, this PR is the foundation of the migration.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Transparent change for now, only issue would be if someone vendors the project.

@CharlyF CharlyF requested review from a team as code owners September 13, 2021 21:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@CharlyF CharlyF added the enhancement New feature or request label Sep 13, 2021
@CharlyF CharlyF added this to the 0.8 milestone Sep 13, 2021
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from documentation perspective

Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@CharlyF CharlyF merged commit 7f409c6 into main Sep 14, 2021
@CharlyF CharlyF deleted the v2alpha1 branch September 14, 2021 17:28
@@ -5,6 +5,7 @@ resources:
- bases/v1beta1/datadoghq.com_datadogagents.yaml
- bases/v1beta1/datadoghq.com_datadogmetrics.yaml
- bases/v1beta1/datadoghq.com_datadogmonitors.yaml
- bases/datadoghq.com_datadogagents.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be present

@clamoriniere clamoriniere modified the milestones: v0.8, v0.8.0 Oct 28, 2021
@khewonc khewonc mentioned this pull request May 17, 2022
mftoure pushed a commit that referenced this pull request Oct 3, 2024
* restructuring project to support multi-group

* adding storage option and new openapi gen

* adding v2alpha1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants