-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the "Not" Operator #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
reviewed
Dec 8, 2023
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
…sts to make sure that regex inputs work with the not operator
skarimo
reviewed
Dec 15, 2023
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
skarimo
reviewed
Dec 18, 2023
skarimo
reviewed
Dec 18, 2023
Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com>
skarimo
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR adds support for the
Not
Operator when defining the filter for a particular resource.This was in response to question that was brought up by a Support Engineer where their client asked if the tool supported the the Not operation. This wasn't supported but was determined that it was a useful option to have.
Description of the Change
The change for this was to basically, invert the boolean result that was generated when we compared the default regex (Exact Match) to the resource attribute.
Alternate Designs
Possible Drawbacks
Verification Process
To verify that the change is working as intended, I manually made sure that when using the new operator, that I received the expected results.
I also added additional tests that would confirm that the
Not
Operator was working as intended. I took all of the tests that verified the filtering behavior and then created inverse versions of them.Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.