_TimedContextManagerDecorator enter -> self #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have _TimedContextManagerDecorator return self from __enter__ so that it can
be modified within the block. e.g.
with timed('foo.bar', tags=['key:val']) as timer:
# do some stuff
if blip:
timer.tags.append('result:blip')
This can be worked around by assigning timed's result to a var and then
doing a `with timer`, but this is much cleaner.
|
Thanks for the change @ross. I'll review the changes this week, and have it out with the next release by the end of the following week 🚢 . |
| @@ -313,7 +313,9 @@ def test_timed_context(self): | |||
| Measure the distribution of a context's run time. | |||
| """ | |||
| # In seconds | |||
| with self.statsd.timed('timed_context.test'): | |||
| with self.statsd.timed('timed_context.test') as timer: | |||
| self.assertIsInstance(timer, | |||
There was a problem hiding this comment.
I need to update the tests to inherit from unittest. In the meantime would you mind using
t.assert_is_instance(...)rather than
self.assertIsIstance(...)There was a problem hiding this comment.
Almost 😄 it should be t.assert... rather than self.assert...
There was a problem hiding this comment.
Interesting. I've haven't run across nose.tools being used before. Should be in place now.
|
🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have
_TimedContextManagerDecoratorreturnselffrom__enter__so that it can be modified within the block. e.g.This can be worked around by assigning timed's result to a var and then doing a
with timer, but this is much cleaner and shouldn't result in any backwards compatibility issues.