Lambda wrapper - Always flush, even on exceptions #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a final flush would not occur if an uncaught exception occurred in the function wrapped by the Lambda wrapper. Now we always flush, just like mommy taught us!
|
I see the Python 2.7 build failed, but I don't understand how my changes could've caused this. Solar flares? |
|
Hello? |
|
@jmehnle Thank you for the PR. We'll have someone review this and get back to you ASAP with feedback. |
yannmh
approved these changes
Mar 29, 2019
|
The changes look good. Thank you. |
|
@jmehnle Thank you for the PR. It has been included in the latest version of Datadog aws lambda layers for Python. The ARN is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a final flush would not occur if an uncaught exception occurred in the function wrapped by the Lambda wrapper. Now we always flush, just like mommy taught us!