Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dogwrap] Add duration as metric #506

Merged
merged 6 commits into from
Jan 6, 2020
Merged

[dogwrap] Add duration as metric #506

merged 6 commits into from
Jan 6, 2020

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Jan 3, 2020

This would address #4.

@dabcoder dabcoder marked this pull request as ready for review January 3, 2020 10:12
@dabcoder dabcoder requested a review from a team as a code owner January 3, 2020 10:12
zippolyte
zippolyte requested changes Jan 3, 2020
View reviewed changes
datadog/dogshell/wrap.py Outdated Show resolved Hide resolved
zippolyte
zippolyte requested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it something more like what I suggested

datadog/dogshell/wrap.py Outdated Show resolved Hide resolved
datadog/dogshell/wrap.py Show resolved Hide resolved
datadog/dogshell/wrap.py Outdated Show resolved Hide resolved
@dabcoder
Copy link
Contributor Author

dabcoder commented Jan 6, 2020

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte
Copy link
Contributor

/azp run DataDog.datadogpy.integration

zippolyte
zippolyte approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gzussa gzussa merged commit d7f64a8 into master Jan 6, 2020
@gzussa gzussa deleted the davidb/dogwrap-duration-metric branch January 6, 2020 14:14
@dabcoder dabcoder mentioned this pull request Jan 6, 2020
Closed
@zippolyte zippolyte added changelog/Added Added features results into a minor version bump resource/dogshell labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zippolyte zippolyte zippolyte approved these changes

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump resource/dogshell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabcoder @zippolyte @gzussa