Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back telemetry to Dogstatsd client #533

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

hush-hush
Copy link
Member

What does this PR do?

This PR remove the namespace for the telemetry metric to avoid counting them as custom metrics.

We also only flush the telemetry once every 10s (by default) to mirror the behavior from other Dogstatsd clients.

@hush-hush hush-hush requested review from a team as code owners February 11, 2020 01:07
@hush-hush hush-hush added the changelog/Added Added features results into a minor version bump label Feb 11, 2020
@github-actions github-actions bot added the documentation Documentation related changes label Feb 11, 2020
@hush-hush hush-hush changed the title Maxime/remove namespace telemetry Remove namespace telemetry Feb 11, 2020
@hush-hush hush-hush force-pushed the maxime/remove-namespace-telemetry branch 2 times, most recently from 3c49f86 to 65f757e Compare February 11, 2020 21:05
@hush-hush hush-hush force-pushed the maxime/remove-namespace-telemetry branch from 65f757e to 5928c8a Compare February 11, 2020 21:22
@hush-hush
Copy link
Member Author

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte merged commit 74cd4bc into master Feb 19, 2020
@zippolyte zippolyte deleted the maxime/remove-namespace-telemetry branch February 19, 2020 09:01
@zippolyte zippolyte changed the title Remove namespace telemetry Add back telemetry to Dogstatsd client Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump documentation Documentation related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants