[typing] adds type information to some dogstatsd methods #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR builds on #311 and adds type information to a couple commonly used functions in the dogstatsd client
Description of the Change
This adds commented mypy typing to the constructor,
increment
, andgauge
functions of the dogstatsd clientAlternate Designs
N/A
Possible Drawbacks
Users of this library that also use mypy may have their build break if they use the library incorrectly or the types are wrong. This shouldn't cause breakages at runtime.
Verification Process
Ran mypy locally using the tox environment.
Additional Notes
N/A
Release Notes
N/A
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.