Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typing] adds type information to some dogstatsd methods #579

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

vishalkuo
Copy link
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR builds on #311 and adds type information to a couple commonly used functions in the dogstatsd client

Description of the Change

This adds commented mypy typing to the constructor, increment, and gauge functions of the dogstatsd client

Alternate Designs

N/A

Possible Drawbacks

Users of this library that also use mypy may have their build break if they use the library incorrectly or the types are wrong. This shouldn't cause breakages at runtime.

Verification Process

Ran mypy locally using the tox environment.

Additional Notes

N/A

Release Notes

N/A

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@vishalkuo vishalkuo requested a review from a team as a code owner June 26, 2020 19:34
@vishalkuo
Copy link
Contributor Author

bump on this!

@jirikuncar
Copy link
Contributor

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jirikuncar jirikuncar added resource/dogstatsd changelog/Added Added features results into a minor version bump labels Jul 13, 2020
@jirikuncar jirikuncar merged commit 1f143ab into DataDog:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump resource/dogstatsd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants