Use Python 2 compatible configparser explicitly #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes install errors on python 2 with pip<9
Fixes #584
Description of the Change
Specifies the dependency on
configparser
to explicitly beconfigparser<5
Alternate Designs
Ideally this restriction would only be imposed when necessary (pip<9 is being used), but I don't believe there's a way to dynamically alter package requirements based on the version of pip being used.
Possible Drawbacks
Missing new features backported through configparser if they ever reintroduce python 2 support in versions >= 5
Verification Process
Built a new python 2 wheel with
python setup.py sdist bdist_wheel
Created a virtual envrionment with python 2.7.12 and pip 8.1.1
Installed the newly created wheel file into that virtualenvironment using that older version of pip
Additional Notes
N/A
Release Notes
N/A
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.