Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable to disable statsd metric collection #589

Merged
merged 7 commits into from
Aug 6, 2020
Merged

Add environment variable to disable statsd metric collection #589

merged 7 commits into from
Aug 6, 2020

Conversation

dgzlopes
Copy link
Contributor

@dgzlopes dgzlopes commented Jul 15, 2020 •
edited
Loading

What does this PR do?

Closes #576

Adds an environment variable to disable statsd metric collection in certain cases (e.g development).

Description of the Change

Added an environment variable called DD_DOGSTATSD_ENABLE that is set as True by default.

Release Notes

Should be backward compatible.

@dgzlopes
Add variable to disable statsd
5ecc40a 
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
@dgzlopes dgzlopes requested a review from a team as a code owner July 15, 2020 10:32
@zippolyte zippolyte requested a review from a team July 15, 2020 10:38
@zippolyte zippolyte added changelog/Added Added features results into a minor version bump resource/dogstatsd labels Jul 15, 2020
@dgzlopes dgzlopes changed the title Add environment to disable statsd metric collection Add environment variable to disable statsd metric collection Jul 15, 2020
jirikuncar
jirikuncar reviewed Jul 15, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
dgzlopes and others added 2 commits July 15, 2020 12:54
@dgzlopes @jirikuncar
Address review comments DataDog#1
c4de60b 
Co-authored-by: Jiri Kuncar <jiri.kuncar@gmail.com>
@dgzlopes @jirikuncar
Update docs
2b73864 
Co-authored-by: Jiri Kuncar <jiri.kuncar@gmail.com>
@dgzlopes
Copy link
Contributor Author

dgzlopes commented Jul 15, 2020 •
edited
Loading

Thanks for the quick review!

@dgzlopes
Copy link
Contributor Author

Is there anything more I can do? I would love to start using this feature :)

dgzlopes and others added 2 commits July 17, 2020 11:15
@dgzlopes @jirikuncar
Address review
7cfeb68 
Co-authored-by: Jiri Kuncar <jiri.kuncar@gmail.com>
@dgzlopes @jirikuncar
Address review
a9decd9 
Co-authored-by: Jiri Kuncar <jiri.kuncar@gmail.com>
@dgzlopes
Copy link
Contributor Author

I completely forgot about changing it on the rest of the code 😅

@dgzlopes
Fix style nit
035b71c 
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
@dgzlopes
Copy link
Contributor Author

Removed some whitespace too (was making the CI fail).

@jirikuncar
Copy link
Contributor

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgzlopes
Copy link
Contributor Author

Hey @jirikuncar. The PR is missing something? Can I help in any way?

@therve therve merged commit 8ef25b7 into DataDog:master Aug 6, 2020
@wilhelmklopp
Copy link

Exciting stuff!

Thanks for building and shipping this ❤️

@dgzlopes dgzlopes deleted the daniel/disable-statsd-env branch August 6, 2020 14:56
@dgzlopes
Copy link
Contributor Author

Hey @therve, when it's the next release planned? I would love to start using this feature :)

@peterdeme
Copy link

When is this getting released?

@therve
Copy link
Contributor

therve commented Aug 21, 2020

We'll schedule a release for next week, thanks for your patience.

@soulshake
Copy link

Added an environment variable called DD_DOGSTATSD_ENABLE that is set as True by default.

For anyone stumbling across this via Google, the envvar is DD_DOGSTATSD_DISABLE, not DD_DOGSTATSD_ENABLE. ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
changelog/Added Added features results into a minor version bump resource/dogstatsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variable to disable statsd in development
7 participants
@dgzlopes @jirikuncar @wilhelmklopp @peterdeme @therve @soulshake @zippolyte