Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved dogstatsd mypy integration by adding additional type annotations #710

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Improved dogstatsd mypy integration by adding additional type annotations #710

merged 2 commits into from
Feb 2, 2022

Conversation

jahodfra
Copy link
Contributor

@jahodfra jahodfra commented Jan 31, 2022 •
edited by sgnn7
Loading

What does this PR do?

It adds type annotation in similar way how they are done on 'increment'. It helps mypy to analyze functions from this library.

Verification Process

  • I checked out specific branch from my repo and I could remove type: ignore comments in my project.
    It's just comments so there shouldn't be any runtime impact.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@jahodfra jahodfra requested review from a team as code owners January 31, 2022 22:07
@sgnn7 sgnn7 added changelog/Changed Changed features results into a major version bump community Community driven changes severity/minor Minor severity issue labels Feb 1, 2022
@sgnn7 sgnn7 changed the title Extend type annotations for dogstatsd Improve dogstatsd mypy integration by adding additional type annotations Feb 1, 2022
@sgnn7 sgnn7 changed the title Improve dogstatsd mypy integration by adding additional type annotations Improved dogstatsd mypy integration by adding additional type annotations Feb 1, 2022
@sgnn7
Copy link
Contributor

sgnn7 commented Feb 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@sgnn7 sgnn7 merged commit 263cab9 into DataDog:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgnn7 sgnn7 sgnn7 approved these changes

Assignees
No one assigned
Labels
changelog/Changed Changed features results into a major version bump community Community driven changes severity/minor Minor severity issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jahodfra @sgnn7