Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide backwards compatible telemetry counters #801

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

vickenty
Copy link
Contributor

@vickenty vickenty commented Nov 23, 2023

What does this PR do?

Provide backwards compatible telemetry counters for measurements that were removed in #787.

Fixes #795.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@vickenty vickenty marked this pull request as ready for review November 23, 2023 16:42
@vickenty vickenty requested review from a team as code owners November 23, 2023 16:42
Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vickenty vickenty added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 23, 2023
@vickenty vickenty changed the title AMLII-1297 provide backwards compatible telemetry counters Provide backwards compatible telemetry counters Nov 23, 2023
@vickenty vickenty merged commit 5455e9c into master Nov 24, 2023
14 of 15 checks passed
@vickenty vickenty deleted the vickenty/tlm branch November 24, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bytes_dropped is no longer available on DogStatsD client
2 participants