-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --restricted_roles option to Monitors API #809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierreln-dd
added
resource/dogshell
changelog/Added
Added features results into a minor version bump
kind/bug
Bug related issue
severity/minor
Minor severity issue
labels
Dec 26, 2023
skarimo
reviewed
Dec 26, 2023
…the monitor accordingly
skarimo
force-pushed
the
pierrelndd/MNTS-90348
branch
from
January 19, 2024 19:14
2181647
to
cd70e57
Compare
skarimo
reviewed
Jan 25, 2024
skarimo
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/Added
Added features results into a minor version bump
kind/bug
Bug related issue
resource/dogshell
severity/minor
Minor severity issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR adds the "restricted_roles" argument to the Monitors API endpoint (see https://docs.datadoghq.com/api/latest/monitors/#create-a-monitor)
Description of the Change
Added the argument --restricted_roles to all the necessary parsers in order to be able to create/update/validate monitors with restricted roles
Alternate Designs
Possible Drawbacks
Verification Process
I installed the project locally and performed some local tests against my account. I specifically checked that I could add multiple roles, and checked in my DD account that the roles were properly added.
I also ran the tox integration tests but had a lot of errors that were not from my change.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.