RUMM-1001 Handle Custom Timings #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
force-pushed
the
xgouchet/RUMM-1001/custom_timings
branch
from
63ffc5b to
1383877
Compare
xgouchet
added
size-medium
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
============================================
- Coverage 90.15% 90.06% -0.09%
+ Complexity 1359 1357 -2
============================================
Files 160 160
Lines 4641 4619 -22
Branches 518 517 -1
============================================
- Hits 4184 4160 -24
- Misses 286 290 +4
+ Partials 171 169 -2 |
mariusc83
requested changes
Jan 21, 2021
| @@ -102,9 +91,8 @@ internal class RumEventSerializer( | |||
|
|
|||
| internal const val GLOBAL_ATTRIBUTE_PREFIX: String = "context" | |||
| internal const val USER_ATTRIBUTE_PREFIX: String = "$GLOBAL_ATTRIBUTE_PREFIX.usr" | |||
| internal const val VIEW_CUSTOM_TIMINGS_ATTRIBUTE_PREFIX: String = "view.custom_timings" | |||
| // internal const val VIEW_CUSTOM_TIMINGS_ATTRIBUTE_PREFIX: String = "view.custom_timings" | |||
There was a problem hiding this comment.
i think you forgot to remove this
xgouchet
force-pushed
the
xgouchet/RUMM-1001/custom_timings
branch
from
1383877 to
4573aa4
Compare
mariusc83
approved these changes
Jan 21, 2021
xgouchet
force-pushed
the
xgouchet/RUMM-1001/custom_timings
branch
from
4573aa4 to
d725cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up of #473 : refactor the way we persist the customTimings using the generated fields in the ViewEvent.