Skip to content

Commit

Permalink
Merge pull request #359 from DataDog/ncreated/RUMM-917-fix-RUM-objc-i…
Browse files Browse the repository at this point in the history
…nterface-visibility

RUMM-917 Fix Objc API visibility in `RUMMonitor`
  • Loading branch information
buranmert authored Jan 6, 2021
2 parents 0fe108a + 78be0c3 commit f842174
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions Sources/DatadogObjc/RUMMonitor+objc.swift
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,9 @@ public class DDRUMMonitor: NSObject {
public func stopResourceLoading(
resourceKey: String,
response: URLResponse,
size: Int64?,
attributes: [String: Any]
) {
swiftRUMMonitor.stopResourceLoading(resourceKey: resourceKey, response: response, size: size, attributes: castAttributesToSwift(attributes))
swiftRUMMonitor.stopResourceLoading(resourceKey: resourceKey, response: response, attributes: castAttributesToSwift(attributes))
}

public func stopResourceLoadingWithError(
Expand Down
2 changes: 1 addition & 1 deletion Tests/DatadogTests/DatadogObjc/DDRUMMonitorTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class DDRUMMonitorTests: XCTestCase {
),
attributes: ["event-attribute2": "foo2"]
)
objcRUMMonitor.stopResourceLoading(resourceKey: "/resource1", response: .mockAny(), size: 42, attributes: ["event-attribute3": "foo3"])
objcRUMMonitor.stopResourceLoading(resourceKey: "/resource1", response: .mockAny(), attributes: ["event-attribute3": "foo3"])

let rumEventMatchers = try RUMFeature.waitAndReturnRUMEventMatchers(count: 4)

Expand Down

0 comments on commit f842174

Please sign in to comment.