Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appstore upload failure #1443

Closed
ogjurgjej opened this issue Aug 29, 2023 · 6 comments · Fixed by #1444
Closed

Appstore upload failure #1443

ogjurgjej opened this issue Aug 29, 2023 · 6 comments · Fixed by #1444
Assignees
Labels
compilation issue SDK doesn't compile or gives warnings.

Comments

@ogjurgjej
Copy link

The issue

DatadogRUM.xcframework with architecture ios-arm64_arm64e has DatadogInternal.framework embeded inside.
Path: Datadog.xcframework/DatadogRUM.xcframework/ios-arm64_arm64e/DatadogRUM.framework/Frameworks/DatadogInternal.framework

Apple does not allow xcframeworks to embed other xframeworks.
Whey trying to upload to Appstore, it fails with the following error:

Asset validation failed
CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.datadoghq.DatadogInternal' under the iOS application 'SampleApp.app'. (ID: 42fd1e2e-3cf5-4c8b-bbda-c1a30d81ef74)

Asset validation failed
Invalid Bundle. The bundle at 'SampleApp.app/Frameworks/DatadogRUM.framework' contains disallowed nested bundles. (ID: 2ec0e31c-843f-4a2e-80af-66a4b025f832)

Asset validation failed
Invalid Bundle. The bundle at 'SampleApp.app/Frameworks/DatadogRUM.framework' contains disallowed file 'Frameworks'. (ID: 87213736-864b-4796-84b7-691003b64837)

Datadog SDK version:

2.1.1

Last working Datadog SDK version:

n/a

Dependency Manager:

manually, frameworks downloaded from github
https://github.com/DataDog/dd-sdk-ios/releases/download/2.1.1/Datadog.xcframework.zip

Other toolset:

Xcode version:

Xcode 14.3.1 (14E300c)

Swift version:

5.1

Deployment Target:

iOS 11, iPhone + iPad

macOS version:

macOS Ventura 13.5 (22G74)

@ogjurgjej ogjurgjej added the compilation issue SDK doesn't compile or gives warnings. label Aug 29, 2023
@ganeshnj
Copy link
Contributor

Looks related to #1402 (comment)

@ogjurgjej
Copy link
Author

yes, it is the same issue as mentioned in the comment

@ogjurgjej
Copy link
Author

ogjurgjej commented Aug 29, 2023

additional info:
when I manually remove the nested DatadogInternal.framework from DatadogRUM.xcframework upload to Appstore is successful.
Also the app seams to be working without issue.

@ganeshnj
Copy link
Contributor

Are you now taking dependency on both DatadogInternal.framework & DatadogRUM.xcframework directly?

@ogjurgjej
Copy link
Author

yes, the app has the following Datadog dependencies:

  • DatadogCore.xcframework
  • DatadogInternal.xcframework
  • DatadogRUM.xcframework

I am only using DatadogRUM feature, but from my understanding the other frameworks are needed from DatadogRUM as well.

@ganeshnj
Copy link
Contributor

ganeshnj commented Aug 30, 2023

A new version available 2.1.2 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compilation issue SDK doesn't compile or gives warnings.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants