RUMM-1582 Fix DDRUMView
and DDRUMAction
APIs for Objective-C
#583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐞 As noticed in #577 (comment),
DDRUMView
andDDRUMAction
were not properly exposed to Objective-C interface.This PR targets the
1.7.0-beta4
branch, as IMO this is no-risk but high impact fix that can be shipped in1.7.0
.How?
Swift definitions of
DDRUMView
andDDRUMAction
were missing@objc
annotation in theirpublic init()
. Definition forDDRUMView
was there, but it was accidentally removed in this refactoring.Objective-C API tests
Because unexposed or broken Objective-C APIs are recurring problem (#359, #360, #461) I did an improvement to our
DatadogObjc
unit tests by adding smoke tests covering the public interface in Objective-C, e.g.:From now on, when we expose a new API in
DatadogObjc
, we can preview its Objective-C representation right in the test file. Adding test would prevent regression on eventual refactoring and ensure that the API is exposed properly.Review checklist