RUMM-1234 DDNSURLSessionDelegate build errors fixed #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
force-pushed
the
buranmert/RUMM-1234-ddnsurlsessiondelegate-build-fix
branch
from
b05dd10 to
94f23f1
Compare
ncreated
reviewed
Apr 2, 2021
Sources/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
Sources/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
Sources/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
ncreated
reviewed
Apr 6, 2021
Sources/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
buranmert
force-pushed
the
buranmert/RUMM-1234-ddnsurlsessiondelegate-build-fix
branch
3 times, most recently
from
2e68caa to
c7866b2
Compare
|
I changed the content of this PR, now we solve the problem without public API changes |
buranmert
changed the title
ncreated
requested changes
Apr 7, 2021
Tests/DatadogTests/Datadog/Mocks/URLSessionAutoInstrumentationMocks.swift
Outdated
Show resolved
Hide resolved
Tests/DatadogTests/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegateTests.swift
Outdated
Show resolved
Hide resolved
Tests/DatadogTests/Datadog/URLSessionAutoInstrumentation/URLSessionSwizzlerTests.swift
Outdated
Show resolved
Hide resolved
3 tasks
ncreated
requested changes
Apr 8, 2021
Tests/DatadogTests/DatadogObjc/DDNSURLSessionDelegateTests.swift
Outdated
Show resolved
Hide resolved
buranmert
force-pushed
the
buranmert/RUMM-1234-ddnsurlsessiondelegate-build-fix
branch
from
8967ec8 to
12ed66d
Compare
ncreated
requested changes
Apr 9, 2021
Sources/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
Sources/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegate.swift
Outdated
Show resolved
Hide resolved
...tadogTests/Datadog/URLSessionAutoInstrumentation/DDURLSessionDelegateAsSuperclassTests.swift
Show resolved
Hide resolved
buranmert
force-pushed
the
buranmert/RUMM-1234-ddnsurlsessiondelegate-build-fix
branch
from
929a2bb to
81f3cca
Compare
ncreated
approved these changes
Apr 12, 2021
buranmert
deleted the
buranmert/RUMM-1234-ddnsurlsessiondelegate-build-fix
branch
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
In order to ship standalone binaries of the SDK, we need to build our targets with
BUILD_LIBRARY_FOR_DISTRIBUTIONbuild flag.Yet,
@objc open DDNSURLSessionDelegate: DDURLSessionDelegateline was giving compiler errors:either we needed to remove
@objcor superclassDDURLSessionDelegateHow?
In this PR, we removed superclass of
DDNSURLSessionDelegateand needed to make some other changes to make auto-network-tracing work.Review checklist