-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-100 Create dd-sdk-ios
repository on GitHub
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
approved these changes
Dec 10, 2019
buranmert
added a commit
that referenced
this pull request
Jul 27, 2020
We observe non-parseable logs sent to intake In a certain org which has high volumes of logs, %0.3-0.5 of all logs are not parsed properly in dashboard Hypothesis #1 Data being read is malformed, because every malformed log has their malformed part at the very end So if we can read the file later, we can have valid payload This commit implements this hypothesis Hypothesis #2 Write op corrupts the file and we need to watch write ops closely so that we can catch and recover errors This requires major refactoring in File.swift and related files
2 tasks
buranmert
added a commit
that referenced
this pull request
Jul 27, 2020
We observe non-parseable logs sent to intake In a certain org which has high volumes of logs, %0.3-0.5 of all logs are not parsed properly in dashboard Hypothesis #1 Data being read is malformed, because every malformed log has their malformed part at the very end So if we can read the file later, we can have valid payload This commit implements this hypothesis Hypothesis #2 Write op corrupts the file and we need to watch write ops closely so that we can catch and recover errors This requires major refactoring in File.swift and related files
2 tasks
alai97
added a commit
that referenced
this pull request
Sep 23, 2021
Co-authored-by: cswatt <cecilia.watt@datadoghq.com> Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
alai97
added a commit
that referenced
this pull request
Oct 21, 2021
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
This was referenced Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the basic
README.md
content, to see if PR workflow and branches protection is well configured.