RUMM-2745 Decouple Webview Tracking #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
maxep
commented
Dec 12, 2022
Comment on lines
31
to
36
| internal final class GlobalRUMCommandSubscriber: RUMCommandSubscriber { | ||
| func process(command: RUMCommand) { | ||
| let subscriber = Global.rum as? RUMCommandSubscriber | ||
| subscriber?.process(command: command) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not a fan of this, but it helps for injecting a RUMCommandSubscriber instance for testing. Ultimately, The Global.rum and this class will be removed.
There was a problem hiding this comment.
Maybe worth documenting the usage and plan in the header comment?
maxep
commented
Dec 12, 2022
| internal typealias JSON = [String: Any] | ||
|
|
||
| /// Receiver to consume a RUM event coming from Browser SDK. | ||
| internal final class WebViewEventReceiver { |
There was a problem hiding this comment.
This logic is migrated from WebRUMEventConsumer.
maxep
force-pushed
the
maxep/RUMM-2745/any-codable-erasure
branch
2 times, most recently
from
907fda8 to
618ec72
Compare
maxep
force-pushed
the
maxep/RUMM-2745/decouple-webview-tracking
branch
from
4f2a1a1 to
fad9c7b
Compare
maxep
force-pushed
the
maxep/RUMM-2745/any-codable-erasure
branch
from
618ec72 to
cf8c6ae
Compare
maxep
force-pushed
the
maxep/RUMM-2745/decouple-webview-tracking
branch
from
fad9c7b to
fc17e83
Compare
6 tasks
Base automatically changed from
maxep/RUMM-2745/any-codable-erasure
to
develop
December 16, 2022 11:22
maciejburda
approved these changes
Dec 19, 2022
Comment on lines
31
to
36
| internal final class GlobalRUMCommandSubscriber: RUMCommandSubscriber { | ||
| func process(command: RUMCommand) { | ||
| let subscriber = Global.rum as? RUMCommandSubscriber | ||
| subscriber?.process(command: command) | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe worth documenting the usage and plan in the header comment?
ncreated
approved these changes
Dec 20, 2022
| /// `DatadogV1Context` can be safely captured during component initialization. It will never change during component's lifespan, meaning that: | ||
| /// - exposed static configuration won't change; | ||
| /// - bundled provider references won't change (although the value they provide will be different over time). | ||
| internal struct DatadogV1Context { |
Sources/Datadog/FeaturesIntegration/WebView/WebEventBridge.swift
Outdated
Show resolved
Hide resolved
Tests/DatadogTests/Datadog/Logging/LoggingMessageReceiverTests.swift
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ |
This was referenced Jan 18, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The web-view tracking no longer depends on the
DatadogV1Contextand will send raw logs and events through the message-bus.The
DatadogV1Contextcan now be removed as well as its dependencies:CarrierInfoProviderNetworConnectionInfoProviderAppVersionProviderDateCorrectorHow?
The bridge used to inject native context in Browser events, this responsibility moves to the Feature message receiver. The
WebEventBridgenow send raw Browser events on the bus, the Log and RUM receiver will be able to inject current context (e.g ddTags, or RUM context) before writing it tocore.Review checklist
Custom CI job configuration (optional)