RUMM-2819 TLV Lenght Limit #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
commented
Jan 11, 2023
| @@ -79,14 +87,4 @@ class FileTests: XCTestCase { | |||
| XCTAssertEqual((error as NSError).localizedDescription, "The file “file” doesn’t exist.") | |||
| } | |||
| } | |||
|
|
|||
| func testWhenIOExceptionHappens_itThrowsWhenReading() throws { | |||
There was a problem hiding this comment.
Replaced by DataBlockTests.testDataBlockReader_whenIOErrorHappens_itThrowsWhenReading
| XCTAssertEqual(dd.logger.errorLog?.error?.message, "data exceeds the maximum size of 23 bytes.") | ||
| XCTAssertEqual(dd.logger.errorLog?.error?.message, "bytesLengthExceedsLimit(limit: 23)") |
There was a problem hiding this comment.
We will improve telemetry in RUMM-2817
Datadog ReportBranch report: ✅ |
This was referenced Jan 18, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Follow up of #1089
Inject object size limit to TLV to protect from 'Could not allocate memory` crash when a TLV gets corrupted.
Review checklist
Custom CI job configuration (optional)