Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick Doc updates into Master #1199

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Cherry Pick Doc updates into Master #1199

merged 2 commits into from
Mar 9, 2023

Conversation

fuzzybinary
Copy link
Member

What and why?

Cherry pick two documentation updates that should be in master.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@fuzzybinary fuzzybinary requested review from a team as code owners March 8, 2023 13:57
buraizu
buraizu approved these changes Mar 8, 2023
View reviewed changes
Copy link

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ncreated
ncreated approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY 💚

@fuzzybinary fuzzybinary merged commit 8d9fad6 into master Mar 9, 2023
@fuzzybinary fuzzybinary deleted the jward/doc-update branch March 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuzzybinary @ncreated @buraizu @rtrieu