[RUMM-2997] Send a crash to both RUM and Logging features #1209
Conversation
plousada
force-pushed
the
plousada/RUMM-2997/send-crash-to-rum-and-logs
branch
2 times, most recently
from
6d7790c to
1897e65
Compare
Datadog ReportBranch report: ✅ |
| @@ -12,7 +12,7 @@ class CrashReporterTests: XCTestCase { | |||
| // MARK: - Sending Crash Report | |||
|
|
|||
| func testWhenPendingCrashReportIsFound_itIsSentAndPurged() throws { | |||
| let expectation = self.expectation(description: "`LoggingOrRUMsender` sends the crash report") | |||
| let expectation = self.expectation(description: "`LoggingAndRUMsender` sends the crash report") | |||
There was a problem hiding this comment.
nit/ it seems to be an artifact of V2 refactoring - neither LoggingOrRUMsender nor LoggingAndRUMsender do exist and instead we use CrashReportSender.
| let expectation = self.expectation(description: "`LoggingAndRUMsender` sends the crash report") | |
| let expectation = self.expectation(description: "`CrashReportSender` sends the crash report") |
| @@ -46,6 +46,47 @@ class CrashReporterTests: XCTestCase { | |||
| XCTAssertTrue(plugin.hasPurgedCrashReport == true, "It should ask to purge the crash report") | |||
| } | |||
|
|
|||
| func testWhenPendingCrashReportIsFound_itIsSentBothToRumAndLogs() throws { | |||
| let expectation = self.expectation(description: "`LoggingAndRUMsender` sends the crash report to both features") | |||
There was a problem hiding this comment.
| let expectation = self.expectation(description: "`LoggingAndRUMsender` sends the crash report to both features") | |
| let expectation = self.expectation(description: "`CrashReportSender` sends the crash report to both features") |
| @@ -74,7 +115,7 @@ class CrashReporterTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testWhenPendingCrashReportIsFoundButItHasUnavailableCrashContext_itPurgesTheCrashReportWithNoSending() { | |||
| let expectation = self.expectation(description: "`LoggingOrRUMsender` does not send the crash report") | |||
| let expectation = self.expectation(description: "`LoggingAndRUMsender` does not send the crash report") | |||
There was a problem hiding this comment.
| let expectation = self.expectation(description: "`LoggingAndRUMsender` does not send the crash report") | |
| let expectation = self.expectation(description: "`CrashReportSender` does not send the crash report") |
There was a problem hiding this comment.
Great work 👍 another approach would be to send a single "crash" message on the bus, and make the Logs Feature consume that one instead of "crash-log". It would simplify a bit the implementation, but it would have to print a more generic warning if the crash is not consumed at all.
I can also do that if you prefer. It depends if we want to give importance to the fact that the crash is consumed by a specific feature, or by any feature. |
plousada
force-pushed
the
plousada/RUMM-2997/send-crash-to-rum-and-logs
branch
from
1897e65 to
f575c72
Compare
|
Yes, I am for simplicity :) I think we would benefit from sending the crash only once on the bus, mostly because it will save an encode/decode operation on the message-bus and it could be consume by any Feature. Also, this warning won't have much visibility as it will be printed when the app restart only. |
What and why?
Sends crash information both to Logs and RUM Features, as opposed to only RUM if both features are enabled.
Adopted a logging strategy similar to Android.
How?
A brief description of implementation details of this PR.
Review checklist
Custom CI job configuration (optional)