REPLAY-1457 Enhance UISwitch element masking
#1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that selected value cannot be seen if `.maskAll` strategy is set.
ncreated
commented
Mar 21, 2023
| } | ||
| } | ||
|
|
||
| private func createMasked(with builder: WireframesBuilder) -> [SRWireframe] { |
There was a problem hiding this comment.
Instead of adding new method, we could patch the previous one with if isMasked in several places. I tried this, but after all it was less readable and coherent than here.
fuzzybinary
approved these changes
Mar 22, 2023
maxep
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR enhances masking behaviour for
UISwitchelements when.maskAllpolicy is set. Now, the selected value (ON / OFF) is fully hidden and cannot be inferred:How?
Added distinct method for "rendering" masked switch.
Review checklist
Custom CI job configuration (optional)