REPLAY-1510 Button image background support #1240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds support for image backgrounds for UIButton.
As extra we provided similar solution for any image background that's coming from
UIImageView
which is direct childof
_UIBarBackground
which covers scenarios forUINavigationBar
,UITabBar
andUIToolbar
.Other considered solution was involving separate recorders, but this would introduce way more complexity.
Once we find reasons for adding separate recorders for any of the classes above we can gradually move the logic from the image generic to control specific image recorder.
How?
Solution is based on UIImageView and UIImage extensions that provide number of flags representing a state of control. These states are taken into account in recording and tinting predicate of the recorder.
Review checklist
Custom CI job configuration (optional)