REPLAY-1516 Unsupported ViewController placeholder #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add snapshot test |
maciejburda
force-pushed
the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
from
c131e4a to
7f48846
Compare
maciejburda
force-pushed
the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
from
4b8e08e to
31b781f
Compare
|
As discussed - removed snapshot tests for these |
maciejburda
force-pushed
the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
from
31b781f to
c02076c
Compare
ncreated
requested changes
Apr 14, 2023
...wTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UnsupportedViewControllerRecorder.swift
Outdated
Show resolved
Hide resolved
maciejburda
force-pushed
the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
from
c02076c to
f7393fa
Compare
|
Depends on this: |
maciejburda
force-pushed
the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
3 times, most recently
from
296238f to
949ad27
Compare
maciejburda
force-pushed
the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
from
949ad27 to
c5b1e04
Compare
ncreated
requested changes
May 4, 2023
DatadogSessionReplay/SRSnapshotTests/SRHost/Fixtures/BasicViewControllers.swift
Outdated
Show resolved
Hide resolved
DatadogSessionReplay/SRSnapshotTests/SRHost/Fixtures/BasicViewControllers.swift
Outdated
Show resolved
Hide resolved
...corder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UnsupportedViewRecorder.swift
Show resolved
Hide resolved
...corder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UnsupportedViewRecorder.swift
Outdated
Show resolved
Hide resolved
...ay/Sources/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/ViewTreeRecordingContext.swift
Outdated
Show resolved
Hide resolved
...lay/Sources/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/ViewTreeSnapshotBuilder.swift
Outdated
Show resolved
Hide resolved
|
Thanks for great review! I was exploring static content, but unfortunately it's only possible for web view (but not safari vc). Made some changes. Pushing soon :) |
ncreated
approved these changes
May 4, 2023
Comment on lines
+97
to
+99
| private protocol AnyUIHostingViewController: AnyObject {} | ||
| @available(iOS 13.0, *) | ||
| extension UIHostingController: AnyUIHostingViewController {} |
maciejburda
deleted the
maciey/REPLAY-1516-unsupported-viewcontroller-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds placeholders for certain view controllers.
How?
It's done by figuring out the private view class for each unsupported VC.
In that case we ignore it and put a placeholder wireframe in place.
Review checklist
Custom CI job configuration (optional)