RUMM-3194 add sampling rate on Tracer #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzybinary
reviewed
Apr 20, 2023
| @@ -18,6 +20,9 @@ extension String: AllowedSpanAttributeValue {} | |||
| extension UInt64: AllowedSpanAttributeValue {} | |||
| extension Int: AllowedSpanAttributeValue {} | |||
|
|
|||
| // Only numeric values are allowed for `span.ç_dd.*`. | |||
There was a problem hiding this comment.
Is that supposed to be ç_dd or just _dd
The trace's sampling is being handled by the root span, meaning that this is going to be handled automatically by APM's logic on DD servers |
xgouchet
force-pushed
the
xgouchet/RUMM-3194/tracer_sampling_rate
branch
from
c8b7032 to
ed6c70e
Compare
Datadog ReportBranch report: ✅ |
maxep
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Allow customer sampling their traces on the mobile side
How?
A brief description of implementation details of this PR.
Review checklist
Custom CI job configuration (optional)