[porting to develop] RUMM-3266 fix: use arch conditionals to assert arch specific signal #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What and why? On x86 a `fatalError()` results on a SIGILL signal but on an ARM machine it results in a `SIGTRAP`. Hence, the test case fail on the ARM machine. In order to update the CI to ARM, this needs to be fixed. ### How? Use preprocessor macros to check the architecture and then use the appropriate signal.
maxep
approved these changes
May 4, 2023
ganeshnj
changed the title
Datadog ReportBranch report: ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #1273 to
developWhat and why?
On x86 a
fatalError()results on a SIGILL signal but on an ARM machine it results in aSIGTRAP.Hence, the test case fail on the ARM machine. In order to update the CI to ARM, this needs to be fixed.
How?
Use preprocessor macros to check the architecture and then use the appropriate signal.
Review checklist
Custom CI job configuration (optional)