Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-3307 Remove UIWebView #1287

Merged
merged 1 commit into from
May 24, 2023
Merged

RUMM-3307 Remove UIWebView #1287

merged 1 commit into from
May 24, 2023

Conversation

maciejburda
Copy link
Member

What and why?

We should remove any reference to a UIWebView since it's officially deprecated by Apple.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maciejburda maciejburda requested a review from a team as a code owner May 24, 2023 13:30
ncreated
ncreated approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do 👌

@ncreated ncreated merged commit 3656785 into develop May 24, 2023
@ncreated ncreated deleted the maciey/RUMM-3307-remove-uiwebview branch May 24, 2023 16:06
This was referenced May 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciejburda @ncreated @maxep