-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TracingUUID toString string format #1311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! That's a great catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a million @changm4n 🏅. We haven't heard of this causing a problem before, could you please describe what was the impact on your side?
@ncreated The datadog agent on the backend was using the |
Thank you @changm4n, that helps us prioritising release of this fix 👍 |
What and why?
There is a bug in the creation of the
traceparent
of the trace http header.The type of
TracingUUID.rawValue
isUInt64
, but it is converted to 32 bits when converted like [format: "%16x"].When
trace id : 7242571286695202638
(decimal), thetraceparent
header value is being generated as[version]-00000000000000000000000063e94f4e-[parent id]-[trace flags]
now.How?
Use the
%llx
format when converting strings of type UInt64.Review checklist
Custom CI job configuration (optional)