Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename _Datadog_Private to DatadogPrivate #1331

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: rename _Datadog_Private to DatadogPrivate #1331

merged 1 commit into from
Jun 26, 2023

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 26, 2023 •
edited
Loading

Source: alexfanatics@7b32c42

What and why?

#1303

How?

Renaming _Datadog_Private to DatadogPrivate

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@ganeshnj ganeshnj changed the title rename _Datadog_Private to DatadogPrivate fix: rename _Datadog_Private to DatadogPrivate Jun 26, 2023
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 26, 2023 •
edited
Loading

Datadog Report

Branch report: ganeshnj/fix/private-package
Commit report: 7b32c42

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 116 Passed, 0 Skipped, 3m 51.26s Wall Time

@ganeshnj ganeshnj marked this pull request as ready for review June 26, 2023 11:27
@ganeshnj ganeshnj requested a review from a team as a code owner June 26, 2023 11:27
@ganeshnj ganeshnj merged commit bf6b578 into develop Jun 26, 2023
@maciejburda maciejburda deleted the ganeshnj/fix/private-package branch June 26, 2023 12:12
maxep added a commit that referenced this pull request Jun 27, 2023
@maxep
Fix conflict with #1331
a979481
@maxep maxep mentioned this pull request Jun 27, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshnj @maciejburda @alexfanatics