Regenerate rum model #1344
Merged
Regenerate rum model #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
ncreated
approved these changes
Jun 29, 2023
| @@ -300,6 +300,30 @@ public struct RUMActionEvent: RUMDataModel { | |||
| } | |||
| } | |||
|
|
|||
| /// Display properties | |||
| public struct RUMDisplay: Codable { | |||
There was a problem hiding this comment.
public API convention/ (“avoid platform self referencing”) Because now we nest this model, there is no more need to prefix it with RUM*. We add this prefix as part of RUM code decoration:
if fixedName == "Display" {
fixedName = "RUMDisplay"
}Otherwise we're self-referencing the product in public API:
- RUMViewEvent.RUMDisplay
- RUMActionEvent.RUMDisplay
...
+ RUMViewEvent.Display
+ RUMActionEvent.Display
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR updates RUM model.
How?
It required a fix for enum without explicit type in generator, after adding fix I generated the code and added blank mocks. They'll be filled in the follow up PR that adds these metrics to the event.
Review checklist
Custom CI job configuration (optional)