Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-3151 feat: reduce number of view updates by filtering events fro… #1359

Closed
wants to merge 1 commit into from
Closed

RUMM-3151 feat: reduce number of view updates by filtering events fro… #1359

wants to merge 1 commit into from

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jul 4, 2023 •
edited
Loading

Porting #1328 to feature/v2

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@ganeshnj ganeshnj force-pushed the ganeshnj/feat/RUMM-3151-reduce-view-updates branch from 5c75e26 to 31d600e Compare July 4, 2023 12:47
@ganeshnj ganeshnj marked this pull request as ready for review July 4, 2023 13:00
@ganeshnj ganeshnj requested a review from a team as a code owner July 4, 2023 13:00
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 4, 2023 •
edited
Loading

Datadog Report

Branch report: ganeshnj/feat/RUMM-3151-reduce-view-updates
Commit report: 31d600e

✅ dd-sdk-ios: 0 Failed, 0 New Flaky, 156 Passed, 0 Skipped, 15m 33.09s Wall Time

ncreated
ncreated approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganeshnj were there any extra changes other than API updates that you want us to look closer at? Otherwise it looks good to go 👍

@ganeshnj
Copy link
Contributor Author

ganeshnj commented Jul 5, 2023

@ganeshnj were there any extra changes other than API updates that you want us to look closer at? Otherwise it looks good to go 👍

No, it was only for porting but we decided to not include this change in Beta 1. I'm closing this PR without merge.

@ganeshnj ganeshnj closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshnj @ncreated