Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-3450 feat: include session_sample_rate as part of _dd.configuration blob for all RUM events #1410

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Aug 11, 2023

What and why?

Configuration reporting.

How?

  • Update the generated models to sync the models. It required for making sessionReplaySampleRate optional.
  • Whenever a RUMViewEvent, RUMActionEvent, RUMResourceEvent, RUMErrorEvent or RUMLongTaskEvent is created, it includes configured sampling rate.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@ganeshnj ganeshnj force-pushed the ganeshnj/feat/RUMM-3450-sample-rate-rum-event branch 4 times, most recently from 2f6fa31 to 93ef89e Compare August 11, 2023 12:54
@ganeshnj ganeshnj marked this pull request as ready for review August 11, 2023 12:55
@ganeshnj ganeshnj requested a review from a team as a code owner August 11, 2023 12:55
@ganeshnj ganeshnj force-pushed the ganeshnj/feat/RUMM-3450-sample-rate-rum-event branch from ae924e9 to b568a96 Compare August 11, 2023 14:24
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Aug 11, 2023

Datadog Report

Branch report: ganeshnj/feat/RUMM-3450-sample-rate-rum-event
Commit report: b568a96

❄️ dd-sdk-ios: 1 Failed (0 Known Flaky), 2 New Flaky, 158 Passed, 0 Skipped, 15m 23.98s Wall Time

❌ Failed Tests (1)

  • testRUMTapActionScenario - RUMTapActionScenarioTests - Details

    Expand for error
     Segmentation fault. Check error.crash_log for the full crash log.
    

New Flaky Tests (2)

  • testRUMStopSessionScenario - RUMStopSessionScenarioTests - Last Failure

    Expand for error
     Assertion Failure at RUMStopSessionScenarioTests.swift:121: XCTAssertTrue failed
    
  • testTracingManualInstrumentationScenario - TracingManualInstrumentationScenarioTests - Last Failure

    Expand for error
     Thrown Error at TracingCommonAsserts.swift:100: failed: caught error: "Exception(description: "No value for key path \`meta.network.client.available_interfaces\`")"
    

Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like sessionReplaySampleRate should be propagated and set, instead of using nil 🤔

@ganeshnj
Copy link
Contributor Author

Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ganeshnj ganeshnj merged commit 2708080 into develop Aug 16, 2023
@ganeshnj ganeshnj deleted the ganeshnj/feat/RUMM-3450-sample-rate-rum-event branch August 16, 2023 10:01
@ncreated ncreated mentioned this pull request Aug 18, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants