RUM-984 feat: Add sample rate for WebView Log events #1515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds
logsSampleRate
option toDatadogWebViewTracking
. Now, it is possible to set custom sample rate that will be applied to logs received from Browser SDK that runs in a WebView.Counterpart of Android's DataDog/dd-sdk-android#1629
public static func enable( webView: WKWebView, hosts: Set<String> = [], + logsSampleRate: Float = 100, in core: DatadogCoreProtocol = CoreRegistry.default ) {
How?
logsSampleRate
) is added inDatadogWebViewTracking
public API.DatadogLogs
.🎁 As an extra task, I enhanced tests for
MessageEmitter
by separating two concerns:WebViewMessageTests
,MessageEmitterTests
.Review checklist
Custom CI job configuration (optional)
tools/