Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix SR data models validation #1551

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Nov 9, 2023

What and why?

🧰 This PR enables validation of SR data models in CI.

SRDataModels.swift is an auto-generated file created from RUM Events Format schema. This file should not be modified manually and to assure this, this PR enables CI validation with make sr-models-validate (the same way as we check RUM data models).

How?

  1. (in rum-models-generator) The template file for SR models generation was updated with #if os(iOS) macro introduced in fix: DatadogObjc not fully available in 2.1.0 #1428
  2. (in bitrise.yml) The make sr-models-validate is now run in separate CI step.
  3. To make it pass, the manual change inserted to SRDataModels.swift in RUM-1507 Improved diffing #1524 was reverted.
- internal struct SRImageWireframe: Codable {
+ internal struct SRImageWireframe: Codable, Hashable {

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this Nov 9, 2023
@ncreated ncreated marked this pull request as ready for review November 9, 2023 12:10
@ncreated ncreated requested a review from a team as a code owner November 9, 2023 12:10
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 9, 2023

Datadog Report

Branch report: ncreated/chore/fix-sr-models-validation
Commit report: b2ace1b

dd-sdk-ios: 0 Failed, 0 New Flaky, 2652 Passed, 0 Skipped, 10m 16.4s Wall Time

@ncreated ncreated merged commit 05774d7 into develop Nov 10, 2023
7 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-sr-models-validation branch November 10, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants