Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Fix WebView event parser following Browser v5 #1556

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

ncreated
Copy link
Member

What and why?

🍒 Cherry-picking #1552 to have the "Browser V5 Event Parser" fix available in develop without waiting for release/2.5.0.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this Nov 14, 2023
@ncreated ncreated requested review from a team as code owners November 14, 2023 07:32
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 14, 2023

Datadog Report

Branch report: ncreated/fix/fix-browser-v5-events-parser
Commit report: 6f3aaf4

❄️ dd-sdk-ios: 0 Failed, 2 New Flaky, 2411 Passed, 0 Skipped, 5m 19.51s Wall Time

New Flaky Tests (2)

  • testGivenCompositeDelegate_whenInterceptingRequests_itDetectFirstPartyHost - NetworkInstrumentationFeatureTests - Last Failure

    Expand for error
     Assertion Failure at NetworkInstrumentationFeatureTests.swift:568: XCTAssertTrue failed
    
  • testWhenSendingTelemetryMessage_itForwardsToCore - TelemetryTests - Last Failure

    Expand for error
     Abort trap. Check error.crash_log for the full crash log.
    

@ncreated ncreated merged commit e699ec9 into develop Nov 14, 2023
5 checks passed
@ncreated ncreated deleted the ncreated/fix/fix-browser-v5-events-parser branch November 14, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants