Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-402 Remove benchmark tests #1633

Merged
merged 1 commit into from
Jan 17, 2024
Merged

RUM-402 Remove benchmark tests #1633

merged 1 commit into from
Jan 17, 2024

Conversation

maciejburda
Copy link
Member

What and why?

Remove the BenchmarkTests target and files from repo.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maciejburda maciejburda requested review from a team as code owners January 17, 2024 11:00
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 17, 2024 •
edited
Loading

Datadog Report

Branch report: maciey/RUM-402-remove-benchmark-tests
Commit report: bcd003d
Test service: dd-sdk-ios

✅ 0 Failed, 2743 Passed, 0 Skipped, 12m 53.07s Wall Time
🔻 Test Sessions change in coverage: 6 decreased, 5 increased, 3 no change

🔻 Code Coverage Decreases vs Default Branch (6)

This report shows up to 5 code coverage decreases.

  • test DatadogLogsTests iOS 44.73% (Δ-0.16%) - Details
  • test DatadogLogsTests tvOS 44.79% (Δ-0.16%) - Details
  • test DatadogInternalTests tvOS 81.21% (Δ-0.06%) - Details
  • test DatadogInternalTests iOS 81.20% (Δ-0.03%) - Details
  • test DatadogWebViewTrackingTests iOS 23.05% (Δ-0.02%) - Details

maxep
maxep approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maciejburda maciejburda merged commit bd8566d into develop Jan 17, 2024
8 checks passed
@maciejburda maciejburda deleted the maciey/RUM-402-remove-benchmark-tests branch January 17, 2024 15:36
@maciejburda maciejburda mentioned this pull request Jan 17, 2024
Merged
8 tasks
@ncreated ncreated mentioned this pull request Jan 25, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejburda @maxep