chore: Update RUM models to fix webview integration tests #1643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🧰 Fixes the impact of recent update in rum-events-format: DataDog/rum-events-format#177. The PR to Browser RUM schema has changed optionality of the
RUMConnectivity.interfaces
field (non-optional → optional) breaking decoding of browser events in our WebView integration tests:How?
I updated RUM models to the new commit in
rum-events-format
, so we use recent schema for decoding Browser events.This comes along with 2 changes to
rum-models-generator
after DataDog/rum-events-format#177:interfaces: [Interfaces]
to be optional (interfaces: [Interfaces]?
). Because one of the cases inInterfaces
enum is named "none", this caused compiler ambiguity withOptional<Interfaces>.none
. To avoid this, in such situation the generator also uses the prefix (<enumName>None
).🎁 As a bonus, I added an option to the
make
command so we can now generate RUM and SR models for a certain commit of therum-events-format
repo, e.g.:Review checklist
Custom CI job configuration (optional)
tools/