RUM-1833 feat: Link (emergency) crash Logs to crashed RUM session #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
commented
Jan 24, 2024
Comment on lines
-174
to
+195
| .error("Fails to decode crash from RUM", error: error) | ||
| .error("Failed to decode crash message in `LogMessageReceiver`", error: error) |
There was a problem hiding this comment.
This is to differentiate it from other telemetry with the same message.
ganeshnj
reviewed
Jan 25, 2024
Comment on lines
+158
to
+172
| struct PartialRUMViewEvent: Decodable { | ||
| struct Application: Decodable { | ||
| let id: String | ||
| } | ||
| struct Session: Decodable { | ||
| let id: String | ||
| } | ||
| struct View: Decodable { | ||
| let id: String | ||
| } | ||
|
|
||
| let application: Application | ||
| let session: Session | ||
| let view: View | ||
| } |
There was a problem hiding this comment.
Is there any public/internal doc explaining how this correlation work? In case when there an update needed we can always refer.
Also, we have been doing quite a few changes to make the correlation work and so far they have been very organic. These things impact SDK and we should document them somewhere.
There was a problem hiding this comment.
Fair call 👍. I took an extra time to document logs, spans and RUM correlations in this spec (internal).
ganeshnj
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds link to the RUM session for crash reports sent as emergency Log event.
See:
How?
With the "last
RUMViewEvent" being already encoded inCrashContext.data, this PR adds extra logic inDatadogLogsto decode RUM session attributes. Decoding is limited only to these fields that are required so we don't decode the whole event (that wouldn't be even possible asDatadogLogshas no dependency onDatadogRUM).Once decoded, these attributes are attached to
LogEventfollowing the contract between SDK and Datadog app.Except unit tests covering edge cases (like malformed RUM view information), this PR also adds integration unit tests for "Sending Crash Reports as Logs and RUM".
Last, I took extra time to document logs, spans and RUM correlations in this spec (internal).
Review checklist
Custom CI job configuration (optional)
tools/