RUM-1836 feat(otel-tracer): update Example app with Otel tracer use cases #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
approved these changes
Feb 20, 2024
|
|
||
| import UIKit | ||
| import DatadogCore | ||
| import DatadogTrace |
There was a problem hiding this comment.
nit/ In theory, we need import DatadogTrace only to configure the OTel tracer, but here, instrumentation should be possible with only import OpenTelemetryApi, right?
There was a problem hiding this comment.
that's correct, because of SpanTags.resource, I needed the Trace import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Example apps don't have Otel tracer use cases
How?
Copied what the tracer page and replicated the same via OTel tracer.
Single span
RUM integration
Complex span
Review checklist
Custom CI job configuration (optional)
tools/